3-Column using flexbox

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, good work on this one. Layout seems fine and resizes well when going in mobile state.

  A couple of suggestions would be that.

  1. Not using vh as your padding units. I see that you used vh in your padding declarion in the body tag. Now, when I open up dev tools from the bottom, your layout gets squished, because it is only occupying the remaining the viewport's height, since the dev tools already occupied them. I think it will be better if you used a fixed unit, or something that does not scale relative to the viewport like rem em or px. This way, it will make sure that your components won't be destroyed.

  2. Using p tag in the learn more. I think using a tag is a better way since that learn more is supposed to be a link of some sort right or using buttton if that were to be a modal pop up. So p tag is I think not the right choice.

  But still, you did a good okay in here, layout is good just those mentioned above, okay^^

  1

  ---

  

  Andres Villalba•205

  @VILLALBA-22Posted over 3 years ago

  @pikamart Thanks! these suggestions help me too much to improve!

  0