Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hi ChMohit, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add descriptive text in the
alt
attribute of the image - remove
width and height
fromcontainer
class - set
min-height: 100vh
tocontainer
class because Flexbox aligns child items to the size of the parent container - try to add a little
transition
on the element with hover effect
Tip of graphic design: With
font-family:" Big Shoulders Display ", cursive
the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading) ... for the designer it's a really awful font!- I would rather replace it with a
font-family:" Big Shoulders Display ", sans-serif
much more similar to the primary font.
Overall you did well :)
Hope this help and happy coding!
0 - add descriptive text in the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord