3-column preview card

Community feedback

• 

  Abdul Khaliq 🚀•72,580

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  COMPONENT MEASUREMENTS 📐:

  • The width: 100vw property for body is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • So feel free to remove width: 100vw style rule from body this will help you to write efficient code and makes your code more reusable.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Craig Johnson•240

  @craigdev937Posted over 1 year ago

  @0xAbdulKhalid - Hi Abdul, thanks for the tip. 😉

  0
• 

  HelloTechTinu•670

  @tinuolaPosted over 1 year ago

  Nice work @Craig! This is a good project to practice with Grid.

  A few tips:

  • Setting 'grid-template-rows: 1fr' on the body will center the component vertically
  • The 100vw width declaration on the body is not needed--the body is that by default
  • The second display:grid declaration in the media query for the container class is not needed since grid has already been declared prior

  0