Design comparison
SolutionDesign
Solution retrospective
Are there any ways to improve this solution?
Community feedback
- @Jos02378Posted about 3 years ago
Hey @nas096, good job on this solution!
Some suggestions for you:
- You can add a
max-width
to your main tag to keep the structure and shape of your card when the size of the screen is getting bigger. - You can try to follow a CSS naming convention called BEM which can save you from repeating your code. You can watch this video for more information Watch the video.
- You can try to put the div with the class of attribution inside a
footer
tag to clear the accessibility issue in the report.
I hope this helps, good luck!
Marked as helpful1 - You can add a
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord