@correlucas
Posted
👾Hi Abdullah, congrats on completing this challenge!
I saw your solution preview site and I think it's already really good. Here’s some tips for you to improve it:
1.Improve your html markup using meaningful tags to wrap the content, you can replace the div you’ve used for each card with <article>. Remember to wrap big blocks of content with semantic tags and never divs, use divs for small blocks.
2.I saw that for some properties you’ve used em and for others px. In this case it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.
✌️ I hope this helps you and happy coding!
Marked as helpful
