Design comparison
SolutionDesign
Solution retrospective
Open to feedback and tips to improve :)
Community feedback
- @MelvinAguilarPosted over 1 year ago
Hello there ๐. Good job on completing the challenge !
This solution is very organized, and I must highlight the following things you've done well:
- You've used font size in relative units.
- You've implemented custom properties (CSS variables).
- It follows a mobile-first approach.
Now, some advice:
- Consider using only one
<h1>
element on the page for better semantic structure, when you have multiple <h1> elements on a page, it can lead to confusion for search engines in determining the main topic or subject of your page. You can read more about this here ๐.
- Avoid using all uppercase text directly in HTML; instead, use CSS's
text-transform
property to handle casing.
- Question whether the icons of the cars add context to the page. If they are purely decorative, consider using an empty alt (e.g.:
alt=""
) attribute to improve accessibility and prevent unnecessary screen reader announcements.
I hope you find it useful! ๐
Happy coding!
2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord