3-column preview card using HTML, CSS and Vanilla javascript

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hello Anita, Congratulations on completing this challenge!

  Nice solution and nice code! I can see that you paid a lot of attention to your code/design. If you don’t mind I’ve some tips for you:

  1.Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  2.Use max-width: 100% for the cards in the mobile version to allow the cards grow 100% of the width considering the paddings and avoid to have a lateral gap (limited by a fixed width).

  3.Improve your html markup using meaningful tags to wrap the content, you can replace the div you’ve used for each card with <article>. Remember to wrap big blocks of content with semantic tags and never divs, use divs for small blocks.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0

  ---

  

  Anita uka•80

  @neetaukaPosted about 2 years ago

  @correlucas thank you so much😊. I will implement that

  1
• 

  Alin Balog•200

  @FabzusPosted about 2 years ago

  Hello @neetauka!

  Your design looks amazing and the fact that you used Js to show the cards it's a nice touch.

  I recommend this clip from Fireship: https://www.youtube.com/shorts/njdJeu95p6s.

  If I could suggest one thing, if you don't want the text to jump when you hover over it you could modify the border

  button{ border:2px solid var(--Very-light-gray); }

  button:hover{ border:2px solid var(--Very-light-gray); }

  This way the text won't jump anymore.

  Have an amazing day and happy coding! Have fun!

  Marked as helpful

  0

  ---

  

  Anita uka•80

  @neetaukaPosted about 2 years ago

  @Fabzus thank you so much😇

  1