Design comparison
Solution retrospective
Hello, this is my third challenge and took longer than I expected to complete. Had some challenges mostly about responsiveness, but I'm satisfied with the result. Any feedback or suggestions will be greatly appreciated. Thank you for viewing.
Community feedback
- @pikapikamartPosted about 3 years ago
Hey, awesome work on this one. Desktop layout looks great, the site is responsive and the mobile state looks great as well.
Some suggestions would be:
h1
should only be limited to 1 usage per page of the site. Change thoseh1
intoh2
.- Since you are removing the
h1
, you will need to create another but it will be only a screen-reader onlyh1
. Meaning it will be hidden visually but present for screen-reader users. On this, theh1
would have likesr-only
class and the text-content should describe what is the main-content is all about. Theh1
could be placed as the first text inside themain
. Have a look at Grace's solution on this one. Inspect the layout and see the usage ofh1
as well the stylings applied. learn more
is more suitable to be a link, since on a real site, this would act as a page link where the users can "learn more" about a specific car.
Aside from those, great job again on this one and congrats for your 3rd challenge in here^^
Marked as helpful0@hcxwebPosted about 3 years ago@pikamart Hello Raymart, Thank you very much for the valuable and detailed suggestions! I just learned something new and will try to make it better.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord