Design comparison
Solution retrospective
Any tips on how I can improve this design? Thanks!!
Community feedback
- @Bayoumi-devPosted over 2 years ago
Hey Arey, It looks good!...
- Using more than one
<h1>
is allowed by the HTML specification, but is not considered a best practice. Using only one<h1>
is beneficial for screenreader users.
---> Multiple
<h1>
elements on one pageI hope this is useful to you... Keep coding👍
Marked as helpful2@arey-devPosted over 2 years ago@Bayoumi-dev Thank you!! This is a new knowledge for me. I'll make sure to improve my HTML in this project, and keep learning for future challenges/projects ☺️
0@shashreesamuelPosted over 2 years agoI agree with the above comment in terms of deferring from having multiple
h1
tags however in this instance I think it describes the card title in terms of visual hierarchy so it seems to be the most appropriate tag.1 - Using more than one
- @tesla-ambassadorPosted over 2 years ago
Hey Arey, congrats on taking on this challenge! It's really awesome! I think you could just work a little more on the responsiveness at screen widths between 715px - 644px you should change the
flex-direction
to column and maybe set thewidth
of thecontainer
to 80% just so that it's not to far or too close to the borders! Happy Coding!Marked as helpful1@arey-devPosted over 2 years ago@tesla-ambassador I will do exactly as u said!! Thank you for this advice ☺️
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord