3-Column Preview Card solution

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey @agnar-nomad, Congrats on completing this challenge!

  Some suggestions to improve you code:

  • The car images/icons serve no other purpose than to be decorative; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • The headings are being use incorrectly. For this challenge, each heading is equally as important. So best option, is to use <h2> Heading, because it will give each card the same level of importance and it's reusable.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  • Remove the height: 70%; from the .card you will instead use padding / margin to create the height.

  Happy Coding! 👻🎃

  0

  ---

  

  Agnar•220

  @agnar-nomadPosted about 2 years ago

  @vcarames hi thanks for stopping by

  Your comment on the images is very helpful, appreciate it. The buttons are certainly wrong, that's my bad.

  Now, why would I use an h2 element instead of h1, and breaking the hierarchy?

  Also I noticed you going around these projects pasting the exact same reactions to them, while I find your comment about the h2 element incorrect, too.

  0

  

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  @agnar-nomad

  the <h1> Heading is only allowed to be used ONCE per page. You used the <h1> Heading for each heading.

  For this challenge you would use the <h2> Heading since it is has the second highest authority level and it is reusable.

  Regarding my responses to this challenge. People who attempt this challenge (the majority of the time) make the exact same mistakes.

  For example:

  1. They make the mistake you did with you headings.
  2. They use a different heading for each of the headings (h1, h2, and h3).

  Instead of having write everything over and over, it is easier for me to just copy and past my recommendations.

  But before I add my recommendations, I look over their entire code and read it to see if they actually made the errors, I recommend they fix.

  Marked as helpful

  1

  

  Edvan Barbosa•320

  @edvanbarbosaPosted about 2 years ago

  @agnar-nomad,

  Entendo seu comentário pois passei pela mesma experiência. Muitos de nós aprendemos com uma hierarquia onde o h1 pode ser repetido desde que tenha a mesma importância, isso foi o que me foi ensinado.

  @vcarames deixou um comentário sobre esse erro e pesquisando descobri que ele estava certo. De acordo com a w3schools, a tag <h1> só pode ser usada uma vez por página. Link (https://www.w3schools.com/tags/tag_hn.asp).

  Espero ter ajudado ; )

  0