3-column preview card responsive UI

Community feedback

• 

  Ben•770

  @BenConfigPosted almost 3 years ago

  This looks pretty good. I would perhaps try to simplify the HTML as there seem to be some unnecessary elements.

  Maybe something like this:

  <main>
      /* Card 1 */
      <section>
          <h2></h2>
          <p></p>
          <a></a>
      </section>
  
      /* Card 2 */
      <section>
          <h2></h2>
          <p></p>
          <a></a>
      </section>
  
      /* Card 3 */
      <section>
          <h2></h2>
          <p></p>
          <a></a>
      </section>
  </main>
  

  And the images are just for decoration so they can be added using a ::before pseudo-element on each <section>, instead of an HTML element.

  Marked as helpful

  1
• 

  T

  Alex•2,010

  @AlexKMarshallPosted almost 3 years ago

  Hey there, this looks pretty good. It's responsive and doesn't overflow, which is great.

  The HTML is a bit off. You've got a <section class="main">. Just make that a <main>. You need one anyway, and <section> doesn't have any semantic meaning unless it's labelled with aria.

  You've got three <h1> elements. You can only have one of them on the page. That means you'll need to have a hidden page title in an <h1> somewhere, and make the car headings <h2>

  At some screen-sizes the headings get mis-aligned. I'd probably move the headings up into the <header> wrapper and that should make it easier to keep them lined up.

  It's cool that you're experimenting with fluid typography using clamp. It can be a really useful tool. However, for my tastes in this layout it's making things less readable. Generally it's a really useful technique for heading text, less useful for body text. Here I would say your small size of 0.9rem is too small. Body copy shouldn't really go below 1rem. And on big screens 1.94rem just looks too big. Also, having a fluid line-height doesn't make sense here. It will scale with the size of text anyway, so just leave it at 1.5 or 1.25. I think the paragraph text in general would look better at a fixed font-size of 1.25rem.

  I think you could do this with fewer media queries too. You only really need one, which changes the flex-direction of the wrapper from column to row once you get above your breakpoint.

  Marked as helpful

  1

  ---

  

  Vigneshwaraa•220

  @VicgokPosted almost 3 years ago

  @AlexKMarshall Thank you.. The information is helpful, will try it on my next challenge and will check more about aria.

  0
• 

  Vigneshwaraa•220

  @VicgokPosted almost 3 years ago

  This is so helpful and for the svg I'll try the pseudo method on my next challenge.. Thank you.

  0