3-Column Preview Card – Flexbox, Mobile First

Community feedback

• 

  darryncodes•6,370

  @darryncodesPosted about 3 years ago

  Hi Jeff,

  Great solution, well done!

  • flex grow / shrink / basis can be really useful in some situations A Complete Guide to Flexbox
  • alternatively you could use a 1 column grid. Here's another really comprehensive guide

  All the best!

  Marked as helpful

  0

  ---

  

  Jeff•80

  @jcombs0929Posted about 3 years ago

  @darryncodes Thanks for the feedback! I plan to use CSS Grid in future challenges.

  0
• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 3 years ago

  👋Hi Jeff!

  For the spacing, you can use margin or padding, but it's up to you and depending on your HTML markup though.

  I also noticed a .DS_Store file. You should not delete the .gitignore file that has been provided by Frontend Mentor.

  Feedbacks for this solution:

  • Only use one h1 for every page. I recommend to change all your h1 with h2.
  • For the attribution, you can swap the div with footer tag. It's a good practice to use semantic tag.
  • Use remor sometimes em, using px unit will not allow the element to grow or shrink based on user setting.

  That's it! Hopefully this is helpful!

  Marked as helpful

  0

  ---

  

  Jeff•80

  @jcombs0929Posted about 3 years ago

  @vanzasetia Thank you for your feedback!

  0
• 

  VicDev ☪︎•330

  @ViicDevPosted about 3 years ago

  por cierto he realizado esta misma practica sin usar flex-box

  0
• 

  VicDev ☪︎•330

  @ViicDevPosted about 3 years ago

  Hola ando buscando gente para colaborar en estas practicas y ayudarnos en cualquier duda, tengo dudas de esta y otras practicas que he realizado, puedes encontrarme en Github o Twitter en mi siguiente enlace https://github.com/PitagoraStrike espero podamos trabajar juntos y crecer. Un cordial saludo...

  0