Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

3-column preview card (CSS with mobile-first solution using Flexbox)

@JulianLivrone

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello Frontend Mentor Community,

I made this project using mostly Flexbox, with a mobile-first approach. It was really fun to do it, please check it out and say what do you think of it.

Any feedback is welcome! Thank you.

Community feedback

PhoenixDev22 16,950

@PhoenixDev22

Posted

Hello

Congratulation on completing this challenge. Excellent work! I have few suggestions regarding your solution, if you don't mind:

HTML

  • About <h1>it is recommended not to have more than one h1 on the page. Multiple <h1>tags make using screen readers more difficult, decreasing your site’s accessibility. Then swap those <h1> by <h2>.
  • In this challenge, the svgs are much likely to be decorative. For any decorative svgs, each svg tag should have aria-hidden="true" and focusable=”false” attributes to make all web assistive technologies such as screen reader ignore those svgs .`
  • What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.
  • Add border-radius andoverflow hiddento the main container that wraps the three cards so you don't have to set it to individual corners. Aside these, great work on this one. Hopefully this feedback helps.
0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord