3-column preview card component with SCSS

Community feedback

• 

  Charlton Oware•20

  @CharltonOwarePosted about 3 years ago

  Hi Florian. What are your thoughts on semantic html? One of the early projects I looked at when starting html introduced them and I have been giving them some thought. In your submission I would replace the <div class="card_button"> with the <button> tag just for readability/accessibility. This is something I am also still learning and the next contributor may shed further light. Clean code otherwise. Keep advancing!

  Marked as helpful

  1

  ---

  

  Ctrl+FJ•810

  @FlorianJourdePosted about 3 years ago

  @CharltonOware I put my button into a <div> to avoid full width resizing, while my card is on display="flex". You can find the same "mistake" on the picture, which have to be centered left.

  Since the beginning, I'm just feeling not comfy with <button> elements, I generally prefer to style <a> links. But you're probably right, my <div> container should get a different semantic.

  Hope someone with more experience will come around here !

  Keep advancing too !

  0
• 

  CyrusKabir•1,885

  @CyrusKabirPosted about 3 years ago

  hello my dear friend ♥ you did good and clean go ahead for more challenges and for more learning ♥♥♥

  Marked as helpful

  1

  ---

  

  Ctrl+FJ•810

  @FlorianJourdePosted about 3 years ago

  @CyrusKabir Thank you Cyrus ! I guess I could level up to Junior section, but some people are giving so much good advises, it's really helpful to learn good practices ! At least, at the beggining..

  1