Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there!👋 Here are some suggestions to help improve your code:
-
The purpose of the Main Element is to identify the main content of your page. It is not the container of you component. After the main element, you want add a container to wrap you separate components in.
-
Along with the Blank Alt Tag, you also want to include the aria-hidden=“true” to your car images/icons to fully remove them from assistive technology.
-
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.
-
You want to increase 📈 the
padding
andfont-size
to better match the FEM example.
If you have any questions or need further clarification, let me know.
Happy Coding! 👻🎃
Marked as helpful1@TheAce74Posted about 2 years ago@vcarames Thanks a lot, if you have more feedback, do share, especially regarding authoring styles with sass, I just started learning it. Thanks again
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord