3-column preview card component with HTML and CSS

Community feedback

• 

  JyVers•30

  @JyVersPosted over 3 years ago

  Hey Sebastian ! 👋

  Your solution to this challenge seems pretty good!

  But, I noticed 2 problems,

  First, you placed the button using a margin-bottom but the 3 texts don't have the same size so the buttons aren't aligned. You can fix this problem just by specifying a height for your "card-content" div. (by the way, why use a div and not a <p> tag ?)

  And secondly, you put the size of your .card-title in vw, technically it's good for the responsive but in this case if we go down to a screen of for example 400px, the text is very small. You can just put 30px and it works perfectly on all screen sizes!

  I hope these few feedback will help you! 😉

  Have a nice day and keep coding! 😁

  0

  ---

  

  Sebastian•65

  @Basti576Posted over 3 years ago

  @JyVers Thanks for your feedback. I changed the problems you mentioned above. From the "card-content" div to a "p" tag. You are right that this is the better solution here, because my div only had 1 Element, so the "p" tag fits better here. I also set a height to the card-content and now the button alignement looks pretty good.

  Thanks for your correction advices :)

  1