Design comparison
SolutionDesign
Solution retrospective
How readable is my SCSS code and my BEM class name choices in general? Please let me know of any improvements that can be suggested.
Community feedback
- @Robert-RynardPosted almost 3 years ago
Looks good! You can set border-radius on the .page__container and set overflow to hidden that way you don't have to set it individually for the top and bottom sections or in the media query. Nice job!
Marked as helpful1@ruuenPosted almost 3 years ago@Robert-Rynard Thanks mate! Really appreciate your feedback, that's a much more elegant solution.
Have adjusted my code to utilise that and it works great - using overflow completely slipped my mind there!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord