Submitted over 2 years ago
3-column preview card component using React and Tailwind CSS
@king-oldmate
Design comparison
SolutionDesign
Community feedback
- @denieldenPosted over 2 years ago
Hey King, congratulations on completing the challenge! You did a great job π
Let me give you some little tips for optimizing your code:
- Tip of graphic design: with
font-family:" Big Shoulders Display ", cursive
the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with afont-family:" Big Shoulders Display ", sans-serif
much more similar to the primary font. - add
main
tag and wrap the cards for improve the Accessibility - use
button
instead ofp
for the learn more buttons - remove all
margin
from first childdiv
ofroot div
- use flexbox to the body to center the cards
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container
Hope this help! Happy coding π
0 - Tip of graphic design: with
- @Kamasah-DicksonPosted over 2 years ago
Your solution looks great and responsive on smaller devices.
- I like the amount of spacing on the cards.
- Try to fix the accessibility issues.
Besides great job thereπ Happy codingππ»
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord