Travolgi πβ’ 31,400
@denielden
Posted
Hey King, congratulations on completing the challenge! You did a great job π
Let me give you some little tips for optimizing your code:
- Tip of graphic design: with
font-family:" Big Shoulders Display ", cursive
the browser will use the Comics Sans font when it doesn't find the first font indicated (you can seen during loading)... for the designer it's a really awful font! I would rather replace it with afont-family:" Big Shoulders Display ", sans-serif
much more similar to the primary font. - add
main
tag and wrap the cards for improve the Accessibility - use
button
instead ofp
for the learn more buttons - remove all
margin
from first childdiv
ofroot div
- use flexbox to the body to center the cards
- after, add
min-height: 100vh
to body because Flexbox aligns child items to the size of the parent container
Hope this help! Happy coding π
0