3-column preview card component using HTML, CSS and Flexbox

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋Hi Ivan Holguin! My name is Vanza!

  👏 Congratulations for finishing this challenge, especially you have a time estimate, which is one of the skill that you need as a developer.

  I have some feedback that will improve this solution:

  • Instead of using button elements, I would recommend to use anchor tag (<a></a>), since if it is a real website, you want that learn more to go to another page. This is just preference thought, but you get the point.
  • Don't use * universal selector for font-size purposes, since it is mean all elements including html element. It will sometimes cause a serious issue, so for instance, let say you set on your css something like this:

  * {
    font-size: 100px;
  }
  

  • That means, 1rem is equal to 100px and also on any elements, such as a, button, li will be 100px font-size.
  • Try to leave the default font-size as it is, since it will allow the user to change their font-size based on their browser settings.

  That's it! Hopefully this is helpful!

  Marked as helpful

  1

  ---

  

  Ivan Holguin•170

  @AscecentPosted over 3 years ago

  @vanzasetia Thank you so much for the feedback, very helpful :D

  0
• 

  Dylan Estrada•45

  @Worsnop96Posted over 3 years ago

  It's really good at the first look, but there are many things maybe u can implement diferent. Stop using article instead of a single div or sections. Ur css is amazing maybe u can do it better with responsive but it's just practicing. Congrats

  Marked as helpful

  0

  ---

  

  Ivan Holguin•170

  @AscecentPosted over 3 years ago

  @Worsnop96 Thank you for the feedback, appreciate it, I'll have in mind your suggestions in future projects :D.

  0