3-column preview card component using flexbox

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution consists incorrect usage of <h1> so it can cause severe accessibility errors due to incorrect usage of level-one headings <h1>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • In this solution there's three <h1> elements which is this <h1>SEDANS</h1>, <h1>SUVs</h1>, <h1>LUXURY</h1>. You can preferably use <h1> instead of <h2>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  • Example: <h1 class="sr-only">3-column preview card component</h1>

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1
• 

  Steve•1,170

  @peanutbutterjllyPosted over 1 year ago

  when trying to make your .wrapper div have rounded corners, you have the proper syntax with border-radius but you'll need to add the property/value to your .wrapper "overflow: hidden".

  for media queries, I'll link to the CSS tricks article to help you out.

  CSS tricks guide to media queries

  Good job with your solution and keep up the good work!

  Marked as helpful

  1

  ---

  

  Azam Mustufa•360

  @azammustafa66Posted over 1 year ago

  @peanutbutterjlly Thank you so much steve

  1