3-column preview card component using Flexbox

Community feedback

• 

  P

  Remus D. Buhaianu•3,125

  @MiculinoPosted almost 3 years ago

  Good job on completing the challenge, @tahakhairy!

  Your final solution looks pretty much the same as the original design and the responsive design works as expected.

  I looked through your Github repo and I have a few suggestions that I hope will prove useful to you:

  • Format your HTML code better so it's easier to read and understand

  • Use more classes - there are a lot of HTML elements in your code that don't have any classes

  • You can use SVG files with the <img /> element - you don't have to copy all that SVG code

  • Use box-sizing property in your CSS code https://developer.mozilla.org/en-US/docs/Web/CSS/box-sizing

  • It's good practice to do a basic reset https://stackoverflow.com/questions/46923610/css-resetting-margin-and-padding/46923672

  Hope these suggestions will help. Keep it up!

  Marked as helpful

  0

  ---

  

  Taha Khairy•60

  @tahakhairyPosted almost 3 years ago

  @Remus432 Thank you very much. That was really helpful, I appreciate it.

  0