Design comparison
SolutionDesign
Solution retrospective
- Any feedback on the code structure or design is appreciated.
- I am thinking of making individual components into grid as well. Is that a good thing with respect to this project?
Community feedback
- @danielmrz-devPosted 11 months ago
Hello @RoosterRoo!
Your solution looks great!
I have a couple of suggestions for improvement:
-
For semantic reasons, you can replace your
div.container
withmain.container
. This change may have little or no visual impact but it makes your HTML code more semantic and improve SEO optimization as well as the accessibility of your project. -
Also, since the Learn More button is a clickable element, it's nice to add
cursor: pointer
to it. It gives the user a visual indication that's clickable.
I hope it helps!
Other than that, great job!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord