Submitted 11 months ago
3-column preview card component using CSS Flex
@aazs-edu
Design comparison
SolutionDesign
Solution retrospective
- Feedback is more than welcome. Thanks for your time.
Community feedback
- @MelvinAguilarPosted 11 months ago
Hello there π. Good job on completing the challenge !
I have some small suggestions about your code that might interest you.
- You should use only one
<h1>
tag per page. The<h1>
tag is the most important heading tag, This can confuse screen reader users and search engines. This challenge requires thatSedans
,SUVs
andLuxury
are headings, but you can use the<h2>
tag instead of the<h1>
tag. You can read more about this here π.
- You should use the
<a>
tag instead of the<button>
tag because theLearn More
button is a link to another page. Use buttons to perform actions like submitting a form or closing a modal and use links to navigate to another page. You can read more about this here π.
- Not all images should have alt text. Car icons are for decoration purposes only, so they can be hidden from screen-readers by leaving its alt attribute empty. You can read more about this here π.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1 - You should use only one
- @danielmrz-devPosted 11 months ago
Hello @aazs-edu!
Your project looks excelent!
I just have one minor suggestion for you:
- In order to make your project even closer to the original design, you can add
border-radius
to your card, since the original has slightly curved edges. You can add this to yourmain
:
border-radius: 10px; overflow: hidden;
I hope it helps!
Other than this little detail, you did a great job!
0 - In order to make your project even closer to the original design, you can add
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord