3-column preview card component (use only HTML & CSS)

Community feedback

• 

  P

  visualdennis•8,375

  @visualdennissPosted over 1 year ago

  Hello Kayyrbek,

  another great submission! The cards look exactly like in the design!

  I'd have few further suggestions:

  • It looks like your cards container is touching the top edge of the screen on tablet and mobile, you might want to add some padding to the body or margin to the container. Similarly it touches sides when it hits 320px viewport, which is the size for many mobile devices (e.g. Iphone 12 mini) etc.

  • Try to avoid giving fixed heights or max-heights for text containing elements like you have for .card, even if it is in rem, because it can cause issues later on (with changing dynamic data, when the user changes font-sizes, or even browser rendering issues etc.)

  Hope you find this feedback helpful!

  Marked as helpful

  2

  ---

  

  Kayyrbek Perdebekov•130

  @kayyrbeksPosted over 1 year ago

  @visualdenniss Thanks for suggestions, and I implemented it. It's really useful suggestions.

  1
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  ---

  • This solution had generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  1

  ---

  

  Kayyrbek Perdebekov•130

  @kayyrbeksPosted over 1 year ago

  @0xAbdulKhalid Thanks for your recomendation, I implemented it)

  0