Design comparison
Solution retrospective
Hello respected community 👋
I hope you are all well and good ❤️
The challenges are easier and easier which means I am learning a lot and I am so excited to make further progress!
Any constructive feedback is much appreciated! 🙌
Community feedback
- @AdrianoEscarabotePosted almost 2 years ago
Hello Vladimir, how are you? I truly loved your project's outcome, however I have some advice that I hope you'll find useful:
You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader. You can read more in MDN.
I noticed that you used a
button
in which case the best option would be ana
, because in my head when a person clicks on a button written Learn More, he is not confirming a form, or something like, it will be redirected to another page, to Learn More about!to solve this problem do this:
<a href="/" class="btn-sedan">Learn More</a>
The remainder is excellent.
I hope it's useful. 👍
Marked as helpful1@D0vl4Posted almost 2 years ago@AdrianoEscarabote
Hello Adriano 👋
First, thank you for checking my profile, I am honored! 🤠
Second, you are 101% right about the button, I did like that because "a" link is a in-line element, which cannot go up or down, but I just remembered to make it an inline-block, and now it works!!! 🙌🤠😂
So double thank you!
Regarding the <br> tag, again thank you. I deleted, made margin-top higher and now it's all good! 😊
Have a good rest of the day! 🤠
1 - @SinisaVukmirovicPosted almost 2 years ago
Hello!
Try to use more semantic HTML5 elements. Most of errors in your report are about that.
That <article> element should really be a <main> element. This - "Document should have one main landmark" means just that. Landmark means semantic element, in this case <main> element.
Also, this - "All page content should be contained by landmarks" means that no <div>s or any other elements should be outside of those semantic elements, not directly in the body element.
That <div class="attribution" is a perfect candidate to be wrapped inside <footer> semantic element.
Read it, try it, hope it helps!
Marked as helpful1@D0vl4Posted almost 2 years ago@SinisaVukmirovic
Thank you for the constructive feedback! 🙌
I have read it and implemented. Got no errors now! 🤠
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord