3-column preview card component

Community feedback

• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi Joseph, congrats on completing this challenge!

  I've just opened your live site and I can say that you did a great job putting everything together! There's some tips to improve your solution:

  Improve your html markup using meaningful tags to wrap the content, you can replace the div you’ve used for each card with <article>. Remember to wrap big blocks of content with semantic tags and never divs, use divs for small blocks.

  Your solution seems fine, you did a really good job wrapping the content for these 3 cards. Something you can improve here is to use a single class to manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1

  ---

  

  Joseph Morad•190

  @D4R0MPosted about 2 years ago

  Hi Lucas! 👋

  Thank you for your feedback, i very much appreciate it.

  Noted ✍️

  0
• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi Joseph,

  Congratulations for 🎉 for completing this challenge, the card looks great and is responsive. It is also great that you used the right semantic. There are some issues I want to address:

  1. I noticed that you took a desktop-first approach however I would strongly suggest you take the mobile-first approach for future projects as it is easier for responsiveness and rearranging/changing elements within the screen.
  2. For your code, I also noticed that the card gets is not quite aligned between 823px to 850px therefore you should change the media query to max-width: 900px instead and give the margin of your container a value of 0 10px to prevent the card from touching the side of the screen.

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  Marked as helpful

  1

  ---

  

  Joseph Morad•190

  @D4R0MPosted about 2 years ago

  @romila2003 Thank you Romila. Noted :)

  1