3-column-preview-card-component-main with html and css
Design comparison
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Along with the blank
alt tag
, you also want to include thearia-hidden=“true”
to your “car images/icons” to fully remove them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The headings in your component are being used incorrectly. Since the
h1
heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2
heading since it is reusable and it will give each heading the same level of importance.
- Your "buttons" were created with the incorrect element. When the user clicks on the button they should be directed to a different part of you site. The
anchor tag
will achieve this.
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
Marked as helpful1@Devalito67Posted almost 2 years ago@vcarames Thanks for your advices and your time, i really appreciate!!!
0 - Along with the blank
- @HassiaiPosted almost 2 years ago
There is no need to .global-structure a height value, give it display: flex instead of display: inline -flex. To center .global-structure using flexbox, add min-height:100vh to the body. Give column-structure a padding: of 3rem instead specifying which sides get a padding value
In the media query , there is no need to give .global-structure display: flex and height value. There is no need .column-structure a height value and a width value.
Hope am helpful. HAPPY CODING
Marked as helpful1@Devalito67Posted almost 2 years ago@Hassiai Thanks so much it was very very helpful, i use your advices immediatly ;)
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord