Design comparison
Solution retrospective
Hello! I completed the 3-colum card component. A feedback would be much appreciated! :)
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hello there π. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
HTML π:
- You should use only one
<h1>
tag per page. The<h1>
tag is the most important heading tag, This can confuse screen reader users and search engines. This challenge requires thatSedans
,SUVs
andLuxury
are headings, but you can use the<h2>
tag instead of the<h1>
tag. You can read more about this here π.
- You should use the
<a>
tag instead of the<button>
tag because theLearn More
button is a link to another page. Use buttons to perform actions like submitting a form or closing a modal and use links to navigate to another page. You can read more about this here π.
-
Use the
aria-hidden="true"
on the SVG hide the images from screen readersThe main reason for hiding an SVG from screen readers is that SVGs can be used for decorative elements and may not provide any meaningful information to users of assistive technology. Hiding them from screen readers can prevent confusion and reduce the amount of unnecessary information that is read to users.
I hope you find it useful! π Above all, the solution you submitted is great!
Happy coding!
Marked as helpful1 - You should use only one
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord