@correlucas
Posted
👾Hello @iguanasplit, Congratulations on completing this challenge!
Nice code and nice solution! You did a good job here putting everything together. I’ve some suggestions for you:
1.Use relative units like rem or em
instead of px
to have a better performance when your page content resizes on different screens and devices. REM
and EM
does not just apply to font size, but all sizes as well. To save your time you can code your whole page using px
and then in the end use a VsCode plugin called px to rem
to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem
2.You made your html structure entirely with div blocks
but these div doesn't any semantic meaning, for this reason is better you use a better html markup improving your code, for example for each vehicle card you use <article>
instead of the <div>
.
✌️ I hope this helps you and happy coding!
Marked as helpful
@iguanasplit
Posted
@correlucas thank you so much for the resources and the advice, i will be trying this for the next challenges, this was really helpful.
thank you again for commenting in my solutions, have a nice day!