Design comparison
Community feedback
- @quielLovesLasagnaPosted 11 months ago
Nice work, @lekkaaudisy ! Here are some suggestions:
-
I can see that you are doing a great job at the markup but instead of using
div
tags for each box/card, I suggest you usearticle
tags. -
Try adding metadata to add additional information about the website or project when you host it on the internet, you can learn more about it here
-
I noticed that you are importing separate fonts inside your style.css, I suggest you select all of the fonts needed for the project and then import them in bulk (which is a common practice) instead of importing them separately.
That's all :)
0@lekkaaudisyPosted 11 months ago@quielLovesLasagna Thanks for the feedback!
For the bulk import, is it like this?
@import url("https://fonts.googleapis.com/css2?family=Big+Shoulders+Display:wght@700&family=Lexend+Deca:wght@400&display=optional");
or double import and create another file called fonts.css and then import it to style.css?
0@quielLovesLasagnaPosted 11 months ago@lekkaaudisy Yes correct... you don't need to create another file for importing the fonts... just add
@import url("https://fonts.googleapis.com/css2?family=Big+Shoulders+Display:wght@700&family=Lexend+Deca:wght@400&display=optional");
and it should work fine...Marked as helpful0@lekkaaudisyPosted 11 months agoThanks @quielLovesLasagna for all of the suggestion. Already changed the codes now
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord