Design comparison
Solution retrospective
At first, I had difficulties centering my box on the desktop. but I was able to solve that using justify-content and align-items on flexbox. I'm also not really sure of the way I use my media query, any tips would be appreciated.
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hi Robort Gabriel, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
- Every page should have one main landmark
<main>. So replace the div that wraps the whole content with<main>to improve the accessibility. click here
2- All page content should be contained by landmarks, you can understand better by clicking here: click here
We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.
Example:
native HTML5 reference elements:
<body> <header>This is the header</header> <nav>This is the nav</nav> <main>This is the main</main> <footer>This is the footer</footer> </body>ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:
<body> <div role="banner">This is the header</div> <div role="navigation">This is the nav</div> <div role="main">This is the main</div> <div role="contentinfo">This is the footer</div> </body>It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.
Link to read more about: click here
2- Why it Matters
Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.
HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.
Rule Description
It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.
Link to read more about: click here
The rest is great!!
Hope it helps...👍
Marked as helpful0@coding-robortPosted about 2 years ago@AdrianoEscarabote Thanks for your tips, it was helpful
0 - Every page should have one main landmark
- @correlucasPosted about 2 years ago
👾Hello @coding-robort, Congratulations on completing this challenge!
Here’s some tips to improve your solution code:
1.Add the correct color for the background, that in this case is
background-color: #F2F2F22.To make your CSS code easier to work you can create a
single classto manage the content that is mostly the same for the 3 cards (paddings, colors, margins and etc) and another class to manage the characteristics that are different (colors and icon), this way you'll have more control over then and if you need to change something you modify only one class.3.Use units as
remoreminstead ofpxto improve your performance by resizing fonts between different screens and devices.To save your time you can code you whole page using
pxand then in the end use a VsCode plugin called px to rem heres the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem✌️ I hope this helps you and happy coding!
Marked as helpful0@coding-robortPosted about 2 years ago@correlucas Thanks for your tips, it was helpfull
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord