Frontend Mentor | 3-column

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • To not only improve your HTML code but to also identify the main content of you page, you will want to wrap your entire component inside the main element.

  More Info:📚

  MDN Main Element

  • The “car images/icons” in this component are purely decorative; They add no value. So their Alt Tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The headings in your component are being used incorrectly. Since the h1 heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading since it is reusable and it will give each heading the same level of importance.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should be directed to a different part of you site. The anchor tag will achieve this.

  More Info:📚

  MDN The Anchor element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  Marked as helpful

  1
• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace <div class="container"> with the main tag and <div class="attribution"> with the footer tag , this will fix the accessibilities issues.

  To center a content on a page, add min-height:100vh; display: flex; align-items-center: justify-content: center; to the body. instead of using position relative; and it properties.

  give .cards a width value instead of the height value and remove the padding value There is no need to give the .card a height value , replace this with a padding value this will make the content more responsive and avoid overflowing of content.

  There is no need to give .btn a border value, rather give it a border value in .btn:hover. Give each .btn in each card a color that this the same as the background-color of that card,a font weight of 700, and background-color of transparent. You forgot to add a border-radius to the content.

  A media query is required for the mobile design. in the media query change the with value of .cards, and change the value of grid-template-columns to 1fr;

  Hope am Helpful Happy coding

  Marked as helpful

  1

  ---

  

  Shivaraju J•40

  @ShivaaarajPosted almost 2 years ago

  @Hassiai Thank you so much for all these tips, so that I can use them in my future submissions.

  0