Submitted over 2 years ago
3-Column Preview Card Component | Responsive | HTML, CSS
@godkingjay
Design comparison
SolutionDesign
Solution retrospective
Is there anything I should fix?
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi, Jarrian! 👋
Good effort on this challenge! 👍
I see some areas in your code that you can improve.
- All the car icons are decorative images. So, I recommend leaving the
alt=""
empty. This way, the screenreader users can focus on the page content. - I think the "Learn More" buttons are link elements. Depending on what you think will happen after the users click the button. If it is navigating then use the anchor tag, if it is an action then use the button tag. Regardless of what you think, always specify the
type
of thebutton
. It will prevent the button from behaving unexpectedly. - On mobile landscape view,
667px
*375px
, the cards don't have enough room to become a three-column layout. So, I recommend adjusting the breakpoint of the media query.
Hope this helps. 🙂
Marked as helpful1 - All the car icons are decorative images. So, I recommend leaving the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord