@VCarames
Posted
Hey there! π Here are some suggestions to help improve your code:
- The βcar iconsβ in this component are purely decorative. β οΈ Their
alt tag
should be left blank and have anaria-hidden=βtrueβ
to hide them from assistive technology.
More Info:π
[MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)
- The headings in your component are being used incorrectlyβ . Since the
h1
heading can only be used once β οΈ, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2
heading β since it is reusable and it will give each heading the same level of importance.
- For improved accessibility π for your content, it is best practice to use
rem
for yourfont-size
and other property values. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! πππͺ
Marked as helpful