Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

My 3 Column Preview Component Solution

Linda Bβ€’ 270

@Lynd7

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


No particular question but I'm open to any suggestions πŸ˜ƒ

Community feedback

@VCarames

Posted

Hey there! πŸ‘‹ Here are some suggestions to help improve your code:

  • The β€œcar icons” in this component are purely decorative. ⚠️ Their alt tag should be left blank and have an aria-hidden=β€œtrue” to hide them from assistive technology.

More Info:πŸ“š

[MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)

  • The headings in your component are being used incorrectly❌ . Since the h1 heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading βœ… since it is reusable and it will give each heading the same level of importance.
  • For improved accessibility πŸ“ˆ for your content, it is best practice to use rem for your font-size and other property values. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! πŸŽ†πŸŽŠπŸͺ…

Marked as helpful

0
madhausβ€’ 1,040

@festsnusa

Posted

Hi there! Congratulations for completing this challenge.

Here's my feedback:

  • your page is not responsive/adaptive. when i resized my page to mobile resolution, everything looks messy. though you have a media query. you can add "width: 100%" to your component;
  • .DS_Store - i think this file is unnecessary;
  • to make your html code look more concise, you can try to use Pug and add mixin. Also, instead of pure CSS, you can try SCSS.

Hope you found my feedback useful. Happy coding.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord