My 3 Column Preview Component Solution

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “car icons” in this component are purely decorative. ⚠️ Their alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  [MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)

  • The headings in your component are being used incorrectly❌ . Since the h1 heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading ✅ since it is reusable and it will give each heading the same level of importance.

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-size and other property values. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  0
• 

  madhaus•1,040

  @festsnusaPosted almost 2 years ago

  Hi there! Congratulations for completing this challenge.

  Here's my feedback:

  • your page is not responsive/adaptive. when i resized my page to mobile resolution, everything looks messy. though you have a media query. you can add "width: 100%" to your component;
  • .DS_Store - i think this file is unnecessary;
  • to make your html code look more concise, you can try to use Pug and add mixin. Also, instead of pure CSS, you can try SCSS.

  Hope you found my feedback useful. Happy coding.

  Marked as helpful

  0