Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- Move this code to the
Body
element:
.container { height: 100vh; display: flex; flex-direction: column; justify-content: center; align-items: center; margin: 0 auto; }
-
Along with the blank
Alt Tag
, you also want to include thearia-hidden=“true”
to your “car images/icons” to fully remove them from assistive technology. -
The headings in your component are being used incorrectly. Since the
<h1>
heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an<h2>
heading since it is reusable and it will give each heading the same level of importance. -
Your "buttons" were created with the incorrect element. When the user clicks on the button they should be directed to a different part of you site. The
Anchor Tag
will achieve this. -
Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful1@hatemhenchirPosted about 2 years ago@vcarames thank you very much. Really helpfully.
0 - Move this code to the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord