Responsive 3-Column Preview Card

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • The “car icons” in this component are purely decorative. Their alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The headings in your component are being used incorrectly❌ . Since the h1 heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading ✅ since it is reusable and it will give each heading the same level of importance.

  • Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The anchor tag }will achieve this.

  More Info:📚

  MDN The Anchor element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0

  ---

  

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  • Your CSS Reset is being underutilized 📉. To fully maximize 📈 it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-sizeand other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  Marked as helpful

  0

  

  Julius Tamale•150

  @julius-tamalePosted almost 2 years ago

  @vcarames Thank you for the Josh Comeau Reset It has been really a great learn and also your advise about using rem for font-size instead of em has been a great eye opener as I had to do some bit of research and it prove that you were spot on.

  Thank you so much once again.

  0