@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- It is best practice ✅ to use,
classes
for styling purposes, while usingids
solely for JavaScript.
- The “car icons” in this component are purely decorative. ⚠️ Their
alt tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
[MDN Aria-Hidden] (https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#description)
- The headings in your component are being used incorrectly❌ . Since the
h1
heading can only be used once ⚠️, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2
heading ✅ since it is reusable and it will give each heading the same level of importance.
- Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The
anchor tag
}will achieve this.
More Info:📚
- The web development process can be made easier and expedite the process 🚀 by implementing a
CSS Reset
. Here are some examples that you can freely use: Josh Comeau Reset, Eric Meyer Reset
- To properly center ✅ your content to your page, you will want to add the following to your
body
(this method uses CSS Grid):
body {
min-height: 100vh;
display: grid;
place-content: center;
}
More Info: 📚
- Implement a "Mobile First" approach 📱 > 🖥
Mobile devices are now the dominant 👑 way in which people browse the web, it is critical that your website/content looks perfect 💯 on all mobile devices.
More Info: 📚
- For improved accessibility 📈 for your content, it is best practice ✅ to use
rem
for yourfont-size
and other property values. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful