@MelvinAguilar
Posted
Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.
HTML:
- You should use only one
<h1>tag per page. The<h1>tag is the most important heading tag, This can confuse screen reader users and search engines. This challenge requires thatSedans,SUVsandLuxuryare headings, but you can use the<h2>tag instead of the<h1>tag. You can read more about this here.
- You should use the
<a>tag instead of the<button>tag because theLearn Morebutton is a link to another page. Use buttons to perform actions like submitting a form or closing a modal and use links to navigate to another page. You can read more about this here.
CSS:
- Instead of using pixels in font-size, use relative units like
emorrem. The font-size in absolute units like pixels does not scale with the user's browser settings. This can cause accessibility issues for users who have set their browser to use a larger font size. You can read more about this here.
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding! 🎄
Marked as helpful
@approved4me
Posted
@MelvinAguilar For some reason, I get a "Page should contain a level-one heading" Error from Frontend Mentor...😮🙁
@MelvinAguilar
Posted
@approved4me Hi! If you want to remove the error
You can create an '<h1>' element within your 'main' element that will be hidden visually but visible and readable by screen readers. The class "sr-only" hides content visually and here are the styles to copy. e.g.: <h1 class="sr-only">3-column preview card component</h1>
Using an "invisible" <h1> will get rid of the error without changing your solution visually.
Marked as helpful
