3-column preview card component

Community feedback

• 

  PhoenixDev22•16,950

  @PhoenixDev22Posted about 2 years ago

  Hi Cesar Augusto,

  Congratulation on completing this frontend mentor challenge. Your solution looks great. I have some suggestions regarding your solution:

  • In this challenge , as it’s not a whole page, you can have<h1>visually hidden with sr-only. Then you can use <h2> for class="title".

  • In my opinion, the images are much likely to be decorative. For any decorative images, each img tag should have empty alt="" and aria-hidden="true" attributes to make all web assistive technologies such as screen reader ignore those images.

  • What would happen when the user click those learn more? In my opinion, clicking those "learn more" would likely trigger navigation not do an action so button elements would not be right. So you should use the <a>. For future use , it's a good habit of specifying the type of the button to avoid any unpredictable bugs.

  Hopefully this feedback helps.

  0
• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  Fala Cesar, beleza? Parabéns pelo desafio!

  Acabei de ver seu preview site e ficou mto bom, otima soluçao, vc usou tags semanticas e isso fico bem certinho, além da section segurando todos cards vc pode adicionar <article> pra cada um dos cards individualmente, pra melhorar marcação do HTML, já que vai dar outro significado substituindo a div.

  O resto ficou ótimo, 👏

  Espero ter ajudado, continue no foco 😎😎

  0