Design comparison
Community feedback
- @catherineisonlinePosted almost 2 years ago
Great solution.
Make sure to replace button tags with a tag because the purpose of a tag is redirection to another page. Buttons are useful when you want to create some interactivity on the same page, for example, pop-up modal or form submission. Definitely this is not a bug project and this buttons has no purpose right now however and it could potentially be a button as well but less likely, itβs good to have that habit of differentiating buttons and a tagsπ
IF THIS WAS HELPFUL PLEASE MARK IT AS HELPFUL π€©
Marked as helpful1 - @VCaramesPosted almost 2 years ago
Hey there! π Here are some suggestions to help improve your code:
- Along with the blank
alt tag
, you also want to include thearia-hidden=βtrueβ
to your βcar images/iconsβ to fully remove them from assistive technology.
More Info:π
https://www.w3.org/WAI/tutorials/images/
- The headings in your component are being used incorrectly. Since the
h1
heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2
heading since it is reusable and it will give each heading the same level of importance.
- Your "buttons" were created with the incorrect element. When the user clicks on the button they should be directed to a different part of you site. The
anchor tag
will achieve this.
More Info:π
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!ππ
Marked as helpful1 - Along with the blank
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord