used vs code and github

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted almost 2 years ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 📄:

  • Update the following to properly display images

  Do:

  <img src="./images/icon-luxury.svg" alt="">
  

  Instead of:

  <img src="/3 card/images/icon-luxury.svg" alt="">
  

  • Use min-height: 100vh instead of height: 100vh. The height property will not work if the content of the page grows beyond the height of the viewport.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  1

  ---

  

  Syed Baasit•110

  @syedbaasitPosted almost 2 years ago

  @MelvinAguilar Thanks a lot ! you just solved one of my biggest headaches !

  1
• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Unfortunately, your challenge is not complete since it is not responsive 😢, which is a requirement for this challenge; a media query will help. Here is a link to Google Developer’s site that will teach you how make it 100% responsive:

  https://web.dev/learn/design/

  • Do not forget ⚠️ to check your FEM report (It provides value information), to see what is incorrect and update your code with it. This should be done immediately after submitting your challenge.

  • Every site should ALWAYS have ✅ a main element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serves as the component’s container ⚠️.

  More Info: 📚

  MDN Main Element

  • The "sedans", "suvs" and "luxury" are headings ⚠️ so they need be wrapped in a heading element. Since each heading in this card has the same level of importance an h2 heading ✅ will be the best choice.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  0

  ---

  

  Syed Baasit•110

  @syedbaasitPosted almost 2 years ago

  @vcarames Thanks a lot . This Evaluation has cleared up Things for me. Thank you for showing interest in my code. I really appreciate your feedback on my code. This and the other project .

  1