Three column preview card

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  wrap <div class="attribution"> in a footer tag to fix the accessibility issue.

  you forgot to give the body a background-color. Each button must have a font-color that is the same as the background-color of the its div a font weight of 700 and a background-color of transparent. what you have now is the hover effect of the button.

  Increase the padding value for .part-1,.part-2,.part-3 in the media query for smaller screens.

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0
• 

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Do not forgot to check your FEM report, to see what is incorrect and update your code with it right after you submit your challenge.

  The “car icons” in this component are purely decorative. Their alt tag should be left blank and have an aria-hidden=“true” to hide them from assistive technology.

  More Info:📚

  https://www.w3.org/WAI/tutorials/images/

  • The header is being used incorrectly and not needed for this challenge.

  • The headings in your component are being used incorrectly❌ . Since the h1 heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use an h2 heading ✅ since it is reusable and it will give each heading the same level of importance.

  • Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The anchor tag }will achieve this.

  More Info:📚

  MDN The Anchor element

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding!🎄🎁

  0

  ---

  

  バレンタイン 😈•64,190

  @VCaramesPosted almost 2 years ago

  @Bisratworku

  • Move all of these properties to the body and delete the width(not needed) and change theheight: 96%;tomin-height: 100%`:

  main {
      width: 100%;
      height: 96%;
      display: flex;
      justify-content: center;
      align-items: center;
  }
  
  

  • Your CSS Reset is being underutilized. To fully maximize it, you will want to add more to it.

  Here are some examples that you can freely use:

  Josh Comeau Reset

  Eric Meyer Reset

  • For improved accessibility 📈 for your content, it is best practice to use rem for your font-sizeand other property value. While em is best for media-queries. Using these units gives users the ability to scale elements up and down, relative to a set value.

  • Implement a Mobile First approach 📱 > 🖥 Mobile devices are now the dominant way in which people browse the web, it is critical that your website/content looks presentable on all mobile devices.

  More Info:📚

  Mobile First

  0