Design comparison
Solution retrospective
This is my 4th project learning only HTML & CSS Dear community, Please feel free to give me any suggestion. One thing i noted that i still don't know how to adjust a proper HTML, Attributes for screen-reader (role, aria etc.)
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
The “car images/icons” in this component are purely decorative; They add no value. So their
Alt Tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology. -
The “SEDANS”, “SUVS” and “LUXURY” are headings so they need be wrapped in a Heading Element. Since each heading in this card has the same level of importance an
H2
heading will be the best choice. -
Your "buttons" were created with the incorrect element. When the user clicks on the button they should be directed to a different part of you site. The
Anchor Tag
will achieve this.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord