Skip to content
Submitted over 1 year ago

3-column preview card component (💬 HTML & CSS)

Alexandre JOLIET•170
@alexandre-joliet
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...3-column preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hello,

Quite simple project with no issues encountered. I mostly used relatives units this time even if I'm still struggling with these a bit, and it's more guesses at the moment to find the right values 😅!

I put into pratice as well BEM methodology for the first time!

Thank you!

Community feedback

  • Abdul Khaliq 🚀•72,560
    @0xabdulkhaliqPosted over 1 year ago

    Hello there 👋. Congratulations on successfully completing the challenge! 🎉

    • I have other recommendations regarding your code that I believe will be of great interest to you.

    HEADINGS ⚠️:

    • This solution consists incorrect usage of <h1> so it can cause severe accessibility errors due to incorrect usage of level-one headings <h1>
    • Every site must want only one h1 element identifying and describing the main content of the page.
    • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.
    • In this solution there's three <h1> elements, like this <h1>SEDANS</h1>, you can preferably use <h2> instead of <h1>. Remember <h1> provides an important navigation point for users of assistive technologies so we want to use it wisely
    • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)
    • Example: <h1 class="sr-only">3-column preview card component</h1>
    • If you have any questions or need further clarification, you can always check out my submission for this challenge where i used this technique and feel free to reach out to me.

    .

    I hope you find this helpful 😄 Above all, the solution you submitted is great !

    Happy coding!

    Marked as helpful
    1
    Alexandre JOLIET•170
    @alexandre-jolietPosted over 1 year ago

    @0xAbdulKhalid thank you very much for this detailed feedback!

    I'll make the modifications and keep all of it in mind for my next projects 😃!

    0
  • Andrew Teece•380
    @andrewteecePosted over 1 year ago

    Looks great. Nice job! Semantic HTML used, along with BEM naming.

    0
    Alexandre JOLIET•170
    @alexandre-jolietPosted over 1 year ago

    @andrewteece thank you 😊!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord