@danielmrz-dev
Posted
Hello @DarkstarXDD!
Your project looks great!
I noticed that you used a main tag and a div.container to wrap the main content. Unless you have a specific reason to do that, you could've used only the main tag.
It's not like this is a problem, it's just a suggestion for you to optimize it.
I hope it helps!
Marked as helpful
@DarkstarXDD
Posted
@danielmrz-dev Thanks!
Nope that div actually had no purpose. I updated the code according to your feedback. Removed the div.container and modified main tag to be main.container. One less line of code now :)
Appreciate you taking time to go through my code. Thanks again.
@mouwaficbdr
Posted
Hey @DarkstarXDD
First, nice job on this project !
But you know, you can even leave the .container and directly use the main selector in the CSS to define the styles. In general, if the main tag is unique in your project and the style won't be reused elsewhere, directly targeting the tag can be a reasonable approach. However, if you plan to apply a similar style to other elements in the future, adding a class can make your code more flexible and maintainable.
Hope that helps somehow !
Marked as helpful
@DarkstarXDD
Posted
@mouwaficbdr yeah, now that I think about it there was no reason to give the main tag a class. Could have applied the styles directly to the main tag since there is only one of them.
Thanks for the feedback. I appreciate it.
@mouwaficbdr
Posted
My pleasure @DarkstarXDD !
@danielmrz-dev
Posted
I'm glad I could help 😊 @DarkstarXDD
