React, CSS Grid, SCSS

Community feedback

• 

  Favour•2,160

  @Nadine-GreenPosted almost 2 years ago

  HEY GLENN!

  When I previewed your website, I was greeted with the mobile design of your site instead of the desktop design, for user experience, it is advisable to ensure that your mobile design start beneath 1000px, this will prevent it from showing up on laptops/desktops as it did for me.

  Additionally, instead of using a div for <div id="root">, you should opt for a more semantic element like main, this will not only make your site more accessible for disabled people, but you will have one less error as well.

  HOPE I COULD BE OF HELP :)

  HAPPY CODING!

  Marked as helpful

  0
• 

  Glenn•290

  @phoobynetPosted almost 2 years ago

  Hi,

  The breakpoint in the style guide for desktop is 1440px. I do feel this is a little big, but I stuck too it.

  Your are correct about there being no main tag, I forgot to put that back in during refactoring. However, the div#root is just the React "hosting" element. I've just posted an update with a main tag included.

  Thanks for the feedback

  0

  ---

  

  Favour•2,160

  @Nadine-GreenPosted almost 2 years ago

  @phoobynet

  Ok, I understand now, happy I could be of help :)

  0