Design comparison
Community feedback
- @meistensPosted over 2 years ago
To add to what was suggested, your media query is somewhat unnecessary, seeing as you followed a desktop-first approach to build the page.
Here's an example of how it should be (not actual px, so you should modify as it seems you know what you're doing).
@media screen and (min-width: 320px) and (max-width: 420px) { .container { margin: 100px auto 0 auto; max-width: 500px; display: flex; flex-direction: column; max-height: 60vh; }
Marked as helpful0@bharat-bhatiPosted over 2 years ago@meistens Thank you so much for pointing that out. I’m going to fix that error immediately .
0 - @fatlindshehuPosted over 2 years ago
Hello Bharat, Nice work you have done, with few corrections you can make it perfect 🤩
Here are my suggestions: • Use a container that has the three cards and give the container a border radius to fit the design. • Load the correct font from the styles guide. • Align card elements to the left (as they are in the designs) • Buttons need to have more padding on the sides!
Marked as helpful0@bharat-bhatiPosted over 2 years ago@fatlindshehu Thank you so much for your feedback. I really appreciate the details you shared with me about areas where I can improve.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord