@VCarames
Posted
Hey there! 👋 Here are some suggestions to help improve your code:
- Along with the blank
alt tag, you also want to include thearia-hidden=“true”to your “car images/icons” to fully remove them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The headings in your component are being used incorrectly. Since the
h1heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2heading since it is reusable and it will give each heading the same level of importance.
- Your "buttons" were created with the incorrect element. When the user clicks on the button they should be directed to a different part of you site. The
anchor tagwill achieve this.
More Info:📚
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
@Mohsin-93
Posted
@vcarames Hi, isn't a must to have one h1 tag on the page, so is it fine to skip it?
@VCarames
Posted
@Mohsin-93
This a component (a single item that is meant to be part of a larger site) so it’s fine not have an h1 heading on it.
If you wish to not have it show up on your report can create an sr-only h1 heading.
@Mohsin-93
Posted
@vcarames Thanks, also is it a bad practice to add anchor tag in the button tag?
@VCarames
Posted
@Mohsin-93
Combining them? Yes, it is considered bad practice.
Marked as helpful
