Submitted almost 2 years ago
3 column preview card component
@gregoriofrancisco99
Design comparison
SolutionDesign
Solution retrospective
Hello, everyone, this my solution for this challenge. ๐ I had a great time solving this one. ๐
Please, feel free to check my design ๐๏ธ and my code ๐ป. And if you have remarks๐, don't be shy on pointing them.
Community feedback
- @catherineisonlinePosted almost 2 years ago
Look great! After 931px width the attribute container is stuck in the middle of the cards, might want to fix that ๐
1 - @VCaramesPosted almost 2 years ago
Hey there! ๐ Here are some suggestions to help improve your code:
- It is best practice to use, classes for your naming convention as classes are reusable, making them ideal for CSS styling. IDs on the other hand, are not reusable and are mainly used for JavaScript.
- The headings in your component are being used incorrectly. Since the
h1
heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2
heading since it is reusable and it will give each heading the same level of importance.
- The
attribution
should be wrapped in afooter
element.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!๐๐
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord