3 column preview card component

Community feedback

• 

  Gregório Francisco•235

  @gregoriofrancisco99Posted almost 2 years ago

  Greetings, pal! You solution looks really fine, even on mobile. Although there’s a little points where we could improve.

  Saw your html, and If it was me, I shouldn’t had a div to contain everything, while I already have the main tag.

  The h1 tag is a level one heading and there should be only one per page. I noticed you have a couple ones in your code. Because you’re using a section tag, it should be preferable to change it for a h2, because section tags are usually followed by level two heading, a.k.a. h2. You can read more about it HERE.

  To hold the icons, one of the best practices should be to link them to your document using a img tag, instead of an empty div.

  Finally, I would strongly recommend to use an a tag, instead of button. Because, on my way of thinking, the page should take the user to other page, or other panel.

  Well, those are my suggestion. Hope I was able to help. And remember... Keep coding 💻

  0